Skip to content

Conversation

@mmorel-35
Copy link
Contributor

Description

enables and fixes thelper linter issues.

Notice that only naming rules are activated here.

@codecov
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 68.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 68.79%. Comparing base (028f107) to head (ca81892).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
server/storage/wal/testing/waltesting.go 46.66% 8 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
server/storage/backend/testing/betesting.go 87.50% <100.00%> (ø)
server/storage/wal/testing/waltesting.go 60.86% <46.66%> (ø)

... and 43 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19271      +/-   ##
==========================================
+ Coverage   67.58%   68.79%   +1.21%     
==========================================
  Files         421      421              
  Lines       35858    35858              
==========================================
+ Hits        24234    24668     +434     
+ Misses      10200     9762     -438     
- Partials     1424     1428       +4     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 028f107...ca81892. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase this PR, thx

@mmorel-35
Copy link
Contributor Author

/assign @ahrtr

Signed-off-by: Matthieu MOREL <[email protected]>
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, mmorel-35, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius merged commit 27ff3ec into etcd-io:main Apr 23, 2025
31 checks passed
@mmorel-35 mmorel-35 deleted the golangci-lint/thelper branch April 23, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants