Skip to content

Conversation

@mmorel-35
Copy link
Contributor

Description

This uses testify instead of testing for t.Fatal or t.Error calls in server/etcdmain package

Related to #18972

@codecov
Copy link

codecov bot commented Mar 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.82%. Comparing base (f07e2ae) to head (7e422dc).
Report is 208 commits behind head on main.

Additional details and impacted files

see 27 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19612      +/-   ##
==========================================
+ Coverage   68.77%   68.82%   +0.05%     
==========================================
  Files         421      421              
  Lines       35897    35897              
==========================================
+ Hits        24689    24707      +18     
+ Misses       9786     9764      -22     
- Partials     1422     1426       +4     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f07e2ae...7e422dc. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mmorel-35
Copy link
Contributor Author

/assign @serathius

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @mmorel-35

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmhbnz, mmorel-35

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz requested a review from ivanvc April 25, 2025 08:55
@mmorel-35 mmorel-35 closed this by deleting the head repository May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants