[release-3.5] Reject watch request with -1 revision #20709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marek Siarkowicz <[email protected]>
Member
Author
ahrtr
approved these changes
Sep 24, 2025
Member
ahrtr
left a comment
ahrtr
left a comment
There was a problem hiding this comment.
LGTM
pls also update changelog items for 3.5 & 3.6
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
Done #20712 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual cherry-pick of #20693
I dropped test for
rangeEventsfunction as the unit test for ranging events were added in release-3.6 and I didn't find a good way to incorporate it in existing tests.Still I confirmed that release-3.5 branch is affected by the issue. You can open watch on revision -1 and it will return in valid result.