Skip to content

Conversation

@serathius
Copy link
Member

@serathius serathius commented Sep 28, 2025

This is experiment to move create a raft directory within etcdserver.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Sep 28, 2025

Codecov Report

❌ Patch coverage is 92.35294% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.23%. Comparing base (b868ea1) to head (cc53d7a).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
server/etcdserver/raft/raft.go 92.85% 2 Missing and 5 partials ⚠️
server/etcdserver/server.go 90.32% 2 Missing and 4 partials ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
server/etcdserver/adapters.go 66.66% <100.00%> (ø)
server/etcdserver/bootstrap.go 62.68% <100.00%> (-2.07%) ⬇️
server/etcdserver/metrics.go 77.50% <ø> (-3.36%) ⬇️
server/etcdserver/raft/logger.go 51.35% <ø> (ø)
server/etcdserver/raft/metrics.go 100.00% <100.00%> (ø)
server/etcdserver/v3_server.go 75.48% <100.00%> (-1.06%) ⬇️
server/etcdserver/server.go 82.76% <90.32%> (-0.15%) ⬇️
server/etcdserver/raft/raft.go 88.62% <92.85%> (ø)

... and 51 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #20738      +/-   ##
==========================================
- Coverage   69.14%   66.23%   -2.92%     
==========================================
  Files         420      421       +1     
  Lines       34817    34816       -1     
==========================================
- Hits        24074    23060    -1014     
- Misses       9348    10351    +1003     
- Partials     1395     1405      +10     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b868ea1...cc53d7a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@k8s-ci-robot
Copy link

@serathius: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-verify cc53d7a link true /test pull-etcd-verify
pull-etcd-grpcproxy-e2e-amd64 cc53d7a link true /test pull-etcd-grpcproxy-e2e-amd64
pull-etcd-grpcproxy-e2e-arm64 cc53d7a link true /test pull-etcd-grpcproxy-e2e-arm64
pull-etcd-e2e-amd64 cc53d7a link true /test pull-etcd-e2e-amd64
pull-etcd-e2e-386 cc53d7a link true /test pull-etcd-e2e-386
pull-etcd-coverage-report cc53d7a link true /test pull-etcd-coverage-report
pull-etcd-e2e-arm64 cc53d7a link true /test pull-etcd-e2e-arm64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants