Skip to content

Conversation

@ronaldngounou
Copy link
Member

This reflects the use of Go 1.24.10 for compiling binaries.

Contributes to #20891

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ronaldngounou
Once this PR has been reviewed and has the lgtm label, please assign ivanvc for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ivanvc ivanvc mentioned this pull request Nov 7, 2025
17 tasks
@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.15%. Comparing base (5954bf7) to head (ff9b421).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files

see 24 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #20904      +/-   ##
==========================================
- Coverage   69.19%   69.15%   -0.05%     
==========================================
  Files         422      422              
  Lines       34833    34839       +6     
==========================================
- Hits        24102    24092      -10     
- Misses       9334     9340       +6     
- Partials     1397     1407      +10     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5954bf7...ff9b421. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request, @ronaldngounou. We're missing 3.4's entry. Could you please add it? Thanks.

This reflects the use of Go 1.24.10 for compiling binaries

Signed-off-by: ronaldngounou <[email protected]>
@ronaldngounou
Copy link
Member Author

I added an entry for 3.4.

### Dependencies

- Compile binaries using [go 1.24.9](https://github.com/etcd-io/etcd/pull/20807).
- Compile binaries using [go 1.24.10](https://github.com/etcd-io/etcd/pull/20903).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add this for 3.4.39.

3.4.38 is already out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

5 participants