bugc-react: show instruction offsets in hex#253
Merged
Conversation
Render the per-instruction program-counter offset in the bytecode disassembly as a 0x-prefixed hexadecimal value instead of decimal. EVM offsets/PCs are conventionally hex, and the surrounding output (bytecode hex, PUSH immediates) already uses lowercase 0x-prefixed hex, so this makes the instruction listing consistent.
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bytecode disassembly in the BUG playground lists each instruction with its program-counter offset. Those offsets were rendered in decimal, but EVM offsets/PCs are conventionally hexadecimal.
Render each offset as a lowercase,
0x-prefixed hex value, matching the convention already used for the raw bytecode hex and PUSH immediates in the same view. Display-only change; no data or semantics are affected.