ci: migrate CircleCI jobs to Gen2 resource classes#940
Open
hdcesario-op wants to merge 2 commits into
Open
Conversation
Same-size swap mirroring ethereum-optimism/optimism#20917 + #20927. 1 `resource_class: medium` → `medium.gen2` token replacement. No image-pin changes (machine executors, where present, are already pinned). Refs: ethereum-optimism/core-team#2564
The pinned tag ubuntu-2204:2024.08.1 predates Gen2 resource class support and is
rejected by CircleCI when paired with medium.gen2 ("not a valid resource class"
error). Bump to :current to match the pin used in ethereum-optimism/optimism#20927.
Refs: ethereum-optimism/core-team#2564
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Same-size Gen1 → Gen2 swap for the
linuxexecutor in this repo (1 line change inexecutors:, affects 3 jobs). Part of W4 of the CircleCI cost-reduction initiative — ethereum-optimism/core-team#2564.Change
.circleci/config.ymlresource_class: medium→medium.gen2on thelinuxexecutordeveloper-discussion-metrics,developer-issue-metrics,developer-pr-metrics).circleci/config.ymlimage: ubuntu-2204:2024.08.1→image: ubuntu-2204:currentWhy both changes in one PR
The original pin
ubuntu-2204:2024.08.1predates Gen2 support and CircleCI rejects it when paired withmedium.gen2("Job was rejected because resource class medium.gen2, image ubuntu-2204:2024.08.1 is not a valid resource class"). Bumping to:currentmatches the pin used by ethereum-optimism/optimism#20927, where the same combo is running green.Potential downstream effect
Moving the host image from August 2024 to
:currentshifts the underlying OS and language toolchain versions. If any of the 3 metric-collection jobs pin specific apt packages, Python versions, or generated lockfiles, those may need a refresh. Worth a maintainer review before merging — if jobs pass green, no action needed; if they fail on an environment delta, the fix belongs in the job's setup steps or a follow-up commit.Precedent
ubuntu-2204:currentmachine pin)Refs