fix(postage): prevent nil pointer panic in TopUpBatch on transaction …#5332
Merged
gacevicljubisa merged 4 commits intomasterfrom Feb 13, 2026
Merged
fix(postage): prevent nil pointer panic in TopUpBatch on transaction …#5332gacevicljubisa merged 4 commits intomasterfrom
gacevicljubisa merged 4 commits intomasterfrom
Conversation
a1a5628 to
ad373aa
Compare
martinconic
reviewed
Jan 26, 2026
martinconic
approved these changes
Jan 26, 2026
gacevicljubisa
approved these changes
Jan 29, 2026
gacevicljubisa
approved these changes
Jan 29, 2026
|
|
||
| receipt, err := c.sendTopUpBatchTransaction(ctx, batch.ID, topupBalance) | ||
| if err != nil { | ||
| txHash = receipt.TxHash |
Member
There was a problem hiding this comment.
Yes, this is obvious panic, if error happens, receipt is nil
Member
|
Also, we should return txHash only in case that there is no error: so we should adapt for CreateBatch and DiluteBatch Also, it would be good if this is covered in unit tests as well. |
janos
approved these changes
Jan 29, 2026
gacevicljubisa
approved these changes
Jan 29, 2026
martinconic
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Before when running this command you will get panic error, now with the fix:
curl -s -X PATCH "http://localhost:1640/stamps/topup/{BATCH_ID}/2" \ -H "Gas-Price: 10"Config:
Logs:
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):