Conversation
Contributor
akrem-chabchoub
approved these changes
Jan 21, 2026
Member
|
Any idea if this relates to the same issue? |
Contributor
Author
I am not sure about what that PR tries to solve, I was just trying to address the errors occurring when running these checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pt-pss check was failing intermittently with "500 Internal Server Error" or timeouts, even when messages were successfully delivered. This PR adds retry logic and decouples the send confirmation from the message receipt verification.
The pt-gsoc check was timing out under high load when sending many chunks in parallel. This PR introduces a configurable Chunks option, reduces the default parallel chunk count, and implements a smart retry mechanism that only re-broadcasts missing chunks.
PSS Check (pkg/check/pss)
Reliability: Added retry logic (5 attempts) to SendPSSMessage.
False Positive Fix: Modified the check to succeed if the PSS message is received by the listener, even if the SendPSSMessage call returns an error (e.g., timeout).
Configuration: Updated default PostageDepth to 22 to align with testnet configuration.
GSOC Check (pkg/check/gsoc)
Reliability: Implemented a retry mechanism that detects missing SOC updates after the initial run and re-broadcasts only the missing chunks.
Context Safety: Added ctx.Done() checks in the retry loop to ensure the check respects context cancellation immediately.
Configuration:
Added a Chunks option to control the number of parallel updates (default: 3).
Updated default PostageDepth to 22.
Added strict validation: Returns an error if Chunks is ≤ 0 (previously defaulted silently to 3).