fix(ui): resolve Recharts dimension warnings and prevent Websocket close warning #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace ResponsiveContainer with manual dimension management to fix console warnings about -1 width/height during initial render. Changes: - Track container width with ResizeObserver instead of ResponsiveContainer - Pass explicit width and height props directly to BarChart/LineChart - Only render charts when container has valid dimensions (width > 0) - Use fixed height constants matching Tailwind classes (h-20=80px, h-48=192px)
Avoid calling close() on WebSocket in CONNECTING state which causes browser warning "WebSocket is closed before connection is established". Changes: - Add isDisconnectingRef flag to track intentional disconnection - In disconnect(): only close if WebSocket is already OPEN - In onopen: check flag and close immediately if disconnect was called while connecting - Prevent reconnect attempts when intentionally disconnecting
skylenet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.