Issue UI: redact private data like (user, locations, ...) #25039

Copilot · 2025-11-04T13:17:04Z

Adds private data redaction to bug reporter device configurations, preventing personally identifiable information from being exposed in GitHub issues/discussions.

extend template system with private field and marked the relevant fields (user, vin, zip, ...)
add ?private=false query parameter to config endpoints with server-side sanitization
updated issue UI to pass private=false when fetching config data for bug reports
redact config-ui created yaml (tariff, messages, load management, ...)
add e2e test to verify

naltatis · 2025-11-04T13:30:54Z

@copilot lets keep host and ip public for now. You're right, they might contain private data but usually are uncritical local addresses. Errors, mistypings in these fields are often a source of issue. Keeping them visible in bug reports helps us to identify issues.

- Add Private field to Param struct - Mark private parameters in defaults.yaml (host, ip, user, vin, zip, etc.) - Update sanitization to support private parameter redaction - Add private query parameter support to device endpoints - Update Issue.vue to pass private=false for device configs Co-authored-by: naltatis <[email protected]>

Co-authored-by: naltatis <[email protected]>

naltatis · 2025-11-04T13:50:30Z

Note: SKI (Subject Key Identifier) was intentionally excluded per issue instructions stating "SKI/EEBUS certs can be ignored here (other topic)".

@copilot correction. Ski as template param should be marked as private. Ski as part of eebus config (yaml) can be ignored for now.

tests/issue.spec.ts

Co-authored-by: naltatis <[email protected]>

Copilot · 2025-11-04T13:59:11Z

@copilot lets keep host and ip public for now. You're right, they might contain private data but usually are uncritical local addresses. Errors, mistypings in these fields are often a source of is...

Done. Removed private: true from host and ip parameters in 8de4b86. They will now remain visible in bug reports to help with troubleshooting.

Note: SKI (Subject Key Identifier) was intentionally excluded per issue instructions stating "SKI/EEBUS certs can be ignored here (other topic)".

@copilot correction. Ski as template param should...

Done. Added private: true to the ski template parameter in 8de4b86. SKI values will now be redacted in bug reports.

tests/issue.spec.ts

…a testing - Replace locator() with getByLabel() for semantic selectors - Replace separate Audi vehicle test with integrated Shelly meter test - Add username field testing within existing "create issue via ui" test - Use Shelly 1PM which has optional username field (no real credentials needed) - Verify private data (username, password) is redacted in bug report Co-authored-by: naltatis <[email protected]>

naltatis · 2025-11-04T14:11:07Z

@copilot also make long, lat (forecast-base) private.
accessToken and refreshToken should be masked.

tests/issue.spec.ts

- Add private: true to lat and lon parameters (location data) - Add mask: true to accesstoken and refreshtoken (security sensitive) Co-authored-by: naltatis <[email protected]>

Copilot · 2025-11-04T14:18:29Z

@copilot also make long, lat (forecast-base) private.
accessToken and refreshToken should be masked.

Done in f3dac0a:

Marked lat and lon as private: true (location data will be redacted in bug reports)
Marked accesstoken and refreshtoken as mask: true (security tokens will be masked)

naltatis · 2025-11-25T15:02:27Z

@andig please review again. I've removed the redundant field configuration. config_redactor.go now only contains fields that are not (yet) covered by template params.
I had to use go codgen to avoid circular dependencies.

andig · 2025-11-25T15:48:51Z

util/config_redactor.go

 	for k := range res {
-		if slices.Contains(configRedactSecrets, k) {
-			res[k] = "*****"
+		for _, secret := range configRedactSecrets {


Du meinst slices.ContainsFunc ;)

Siehe

if !slices.ContainsFunc(customTypes, func(s string) bool { return strings.EqualFold(res.Type, s) }) { return configReq{}, errors.New("invalid config: yaml only allowed for types " + strings.Join(customTypes, ", ")) }

util/redact_gen.go

util/templates/defaults.yaml

util/templates/types.go

util/templates/template.go

util/redact/redactor.go

andig · 2025-11-25T22:39:30Z

Mhhm. Did the param extraction simplification break something?

util/config_redactor.go

Initial plan

1501b8b

Copilot AI assigned Copilot and naltatis Nov 4, 2025

Copilot started work on behalf of naltatis November 4, 2025 13:17 View session

Copilot AI and others added 3 commits November 4, 2025 13:32

Add e2e test for private data redaction in device configs

5a99f81

Co-authored-by: naltatis <[email protected]>

Refine e2e test for better compatibility

7e86b2c

Co-authored-by: naltatis <[email protected]>

Copilot AI changed the title ~~[WIP] Add function to mask private data in bug reporter~~ Add private data redaction to bug reporter device configs Nov 4, 2025

Copilot AI requested a review from naltatis November 4, 2025 13:51

Copilot finished work on behalf of naltatis November 4, 2025 13:51

Copilot started work on behalf of naltatis November 4, 2025 13:51 View session

naltatis reviewed Nov 4, 2025

View reviewed changes

tests/issue.spec.ts Outdated Show resolved Hide resolved

Address feedback: keep host/ip public, mark ski as private

8de4b86

Co-authored-by: naltatis <[email protected]>

naltatis reviewed Nov 4, 2025

View reviewed changes

tests/issue.spec.ts Outdated Show resolved Hide resolved

Copilot AI requested a review from naltatis November 4, 2025 14:00

Copilot finished work on behalf of naltatis November 4, 2025 14:00

Copilot started work on behalf of naltatis November 4, 2025 14:00 View session

Copilot finished work on behalf of naltatis November 4, 2025 14:09

Copilot started work on behalf of naltatis November 4, 2025 14:11 View session

naltatis reviewed Nov 4, 2025

View reviewed changes

tests/issue.spec.ts Outdated Show resolved Hide resolved

Mark lat/lon as private and accesstoken/refreshtoken as masked

f3dac0a

- Add private: true to lat and lon parameters (location data) - Add mask: true to accesstoken and refreshtoken (security sensitive) Co-authored-by: naltatis <[email protected]>

Copilot finished work on behalf of naltatis November 4, 2025 14:19

Copilot AI requested a review from naltatis November 4, 2025 14:19

Copilot started work on behalf of naltatis November 4, 2025 14:20 View session

naltatis added backlog Things to do later and removed stale Outdated and ready to close labels Nov 18, 2025

naltatis added 2 commits November 25, 2025 15:58

remove redundancy; use template params also for yaml redact

4aea91b

Merge branch 'master' into copilot/mask-private-data-in-bug-reporter

d6d19ef

fmt

d1086b6

andig reviewed Nov 25, 2025

View reviewed changes

util/redact_gen.go Outdated Show resolved Hide resolved

andig reviewed Nov 25, 2025

View reviewed changes

util/templates/defaults.yaml Show resolved Hide resolved

andig reviewed Nov 25, 2025

View reviewed changes

util/templates/types.go Show resolved Hide resolved

andig reviewed Nov 25, 2025

View reviewed changes

util/templates/types.go Outdated Show resolved Hide resolved

andig and others added 2 commits November 25, 2025 17:09

wip

d2b7e09

minimize diff; shorten fixed values

050273c

naltatis reviewed Nov 25, 2025

View reviewed changes

util/templates/template.go Show resolved Hide resolved

andig added 2 commits November 25, 2025 17:37

Simplify

ef386cf

wip

abe5330

andig reviewed Nov 25, 2025

View reviewed changes

util/redact/redactor.go Outdated Show resolved Hide resolved

andig and others added 3 commits November 25, 2025 17:42

Apply suggestion from @andig

86f2017

pin > mask

9bb2ab1

lint

e05abf9

naltatis added 2 commits November 26, 2025 09:41

Merge branch 'master' into copilot/mask-private-data-in-bug-reporter

c6ea580

fix assertion; adjust test

d91a4ea

naltatis reviewed Nov 26, 2025

View reviewed changes

util/config_redactor.go Outdated Show resolved Hide resolved

naltatis marked this pull request as ready for review November 26, 2025 08:52

naltatis and others added 3 commits November 26, 2025 09:55

unmask token for e2e test

28789a6

adjust e2e example

96a63f9

Simplify

3e75079

andig merged commit a65a1ce into master Nov 26, 2025
7 checks passed

andig deleted the copilot/mask-private-data-in-bug-reporter branch November 26, 2025 12:34

Uh oh!

Issue UI: redact private data like (user, locations, ...) #25039

Issue UI: redact private data like (user, locations, ...) #25039

Uh oh!

Conversation

Copilot AI commented Nov 4, 2025 • edited by naltatis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

naltatis commented Nov 4, 2025

Uh oh!

naltatis commented Nov 4, 2025

Uh oh!

Uh oh!

Copilot AI commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

naltatis commented Nov 4, 2025

Uh oh!

Uh oh!

Copilot AI commented Nov 4, 2025

Uh oh!

naltatis commented Nov 25, 2025

Uh oh!

andig Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

andig Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

andig commented Nov 25, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Nov 4, 2025 •

edited by naltatis

Loading

Copilot AI commented Nov 4, 2025 •

edited

Loading