Address architecture review findings: slog logging, /metrics endpoint, dashboard hook, e2e journeys, dependency upgrades - #80
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b27cdc7e63
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| r.mu.Lock() | ||
| defer r.mu.Unlock() | ||
| return r.lastBackupAt |
There was a problem hiding this comment.
在服务重启后但下一次备份尚未执行前，备份目录中已经存在的备份会被 lastBackupAtFromHistory() 用来安排下一次备份，但新暴露的 /metrics 只通过 LastBackupAt() 读取进程内的 lastBackupAt。因此这段代码会返回零值，导致 last_backup_at 从指标中消失，监控会误判当前部署从未成功备份；建议这里也读取已有的 history 结果或复用相同的历史合并逻辑。
Useful? React with 👍 / 👎.
Address Codex review P2: /metrics last_backup_at read only the in-memory lastBackupAt, so after a service restart it returned the zero value until the next backup ran, making monitoring report that no backup ever succeeded. LastBackupAt now reuses the same history-merge logic as the scheduling path.
|
Addressed the Codex review feedback: Fixed: P2 — include persisted backup history in /metrics
Verification: Commit: @codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
Addresses the findings from the architecture review of the previous PR (#78) and the follow-up code-review loop. Seven coherent commits:
log/slog(13 files, incl. app/poller/repository/service/cpa), unify gin bridge and level mapping (trace→debug,fatal/panic→error)GET /metricsruntime snapshot — uptime, poller state, rollup backfill status, last backup time,redis_inbox_pendingbacklog, and Redis inbox processing throughput counters + derived rate per minute (failed/empty batches excluded); DB read failures degrade todb_unavailable: trueinstead of failing the endpointindex.lazy.tsx562 → 101 lines; page state/queries/view-model extraction intouseUsageDashboardhook; presentation components moved tocomponents/intelligence; DOM/aria-labels unchanged (covered by e2e)mock-api.ts; mobile spec reuses the shared mocksVerification
make verify-backend: go build + 17 packages tests +go vet— all greenmake verify-frontend: eslint + 114 vitest tests + typecheck + build — all greenmake verify-docker(golang:1.25-alpine, CGO SQLite) — build success/healthz,/metrics, embedded frontend HTML all served correctlyCompatibility
/metricsis a new public endpoint (same visibility as/healthz), documented in ADR-0007; reverse proxy can enforce auth for deployments that need it.Auto-close: none