Skip to content

Conversation

@wangchen615
Copy link

  1. change the package management using dep
  2. change the code structure for easy import as packages to reuse the functions defined in prioritize.go, etc.

Fix issue #8

Copy link
Owner

@everpeace everpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wangchen615 Wow, Thank you for your great contribution. Looks great to me overall. Would you mind me requesting housekeeping tasks (mainly documentation) before merging this 🙇 ?

  • Could you rename the package so that it fits this repo?
  • Could you rewrite README to fit this repository (and delete README.org)? Please include the credit to your contribution.
  • Could you include deployment example in README as previous? It would be better first touch for new commers.

@wangchen615
Copy link
Author

wangchen615 commented Dec 19, 2019

Hi, @everpeace , thanks for the comments. Sorry for coming back to this late. I made the above changes, could you review again please?

@everpeace
Copy link
Owner

@wangchen615 Thanks for your adjustment work!! However, #10 was submitted recently and I merged it because it keeps using go module and I prefer this because go module is the current de-facto.

But, I think the ease of import is important as you pointed out. Thus, would you mind kindly re-working this pr so that this can still use go module?? I'm very happy if you could contribute.

Sorry for your inconvenience 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants