-
Notifications
You must be signed in to change notification settings - Fork 87
Restructure the code for easy import #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
everpeace
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wangchen615 Wow, Thank you for your great contribution. Looks great to me overall. Would you mind me requesting housekeeping tasks (mainly documentation) before merging this 🙇 ?
- Could you rename the package so that it fits this repo?
- Could you rewrite
READMEto fit this repository (and deleteREADME.org)? Please include the credit to your contribution. - Could you include deployment example in
READMEas previous? It would be better first touch for new commers.
|
Hi, @everpeace , thanks for the comments. Sorry for coming back to this late. I made the above changes, could you review again please? |
|
@wangchen615 Thanks for your adjustment work!! However, #10 was submitted recently and I merged it because it keeps using go module and I prefer this because go module is the current de-facto. But, I think the ease of import is important as you pointed out. Thus, would you mind kindly re-working this pr so that this can still use go module?? I'm very happy if you could contribute. Sorry for your inconvenience 🙇 |
depFix issue #8