fix(ssh): replace derived Debug with manual impls that redact credentials#1197
Merged
fix(ssh): replace derived Debug with manual impls that redact credentials#1197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1189
#[derive(Debug)]with manualDebugimpls forSshConfigandSshTargetthat redactdefault_password,default_private_key,private_key, andpasswordfields with[REDACTED]BotAuthConfigwas already fixed in fix(network): zeroize bot-auth seed on drop and harden secret handling #1195Why
Formatting these structs with
{:?}would dump plaintext passwords and private keys into logs, error messages, panic backtraces, and LLM context.Test plan
test_debug_redacts_credentialsforSshConfig— verifies password and key are hiddentest_debug_redacts_credentialsforSshTarget— verifies password and key are hidden, host is visible