Skip to content

fix(ssh): replace derived Debug with manual impls that redact credentials#1197

Merged
chaliy merged 1 commit intomainfrom
fix/issue-1189-debug-redact
Apr 11, 2026
Merged

fix(ssh): replace derived Debug with manual impls that redact credentials#1197
chaliy merged 1 commit intomainfrom
fix/issue-1189-debug-redact

Conversation

@chaliy
Copy link
Copy Markdown
Contributor

@chaliy chaliy commented Apr 11, 2026

Summary

Closes #1189

Why

Formatting these structs with {:?} would dump plaintext passwords and private keys into logs, error messages, panic backtraces, and LLM context.

Test plan

  • test_debug_redacts_credentials for SshConfig — verifies password and key are hidden
  • test_debug_redacts_credentials for SshTarget — verifies password and key are hidden, host is visible
  • All 2319 bashkit unit tests pass

…ials

Closes #1189 — SshConfig and SshTarget derived Debug, leaking passwords
and private keys into logs, error messages, and LLM context.
BotAuthConfig was already fixed in #1195.
@chaliy chaliy merged commit 00c971b into main Apr 11, 2026
27 checks passed
@chaliy chaliy deleted the fix/issue-1189-debug-redact branch April 11, 2026 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sec(ssh): Debug derive on SshConfig/SshTarget/BotAuthConfig leaks credentials in logs

1 participant