Skip to content

test: add regression guard for nil-error invariant on failure conditions #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

test: add regression guard for nil-error invariant on failure conditions #24

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a36e84
Initial plan
Copilot Mar 26, 2026
ff52877
test: add regression test ensuring failure condition is never called …
Copilot Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions hoglet_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,25 @@ func TestHoglet_Do(t *testing.T) {
}
}

// TestCircuit_failure_condition_never_called_with_nil ensures that the nil guard in hoglet.go prevents
// custom failure conditions from ever receiving a nil error.
func TestCircuit_failure_condition_never_called_with_nil(t *testing.T) {
// panicOnNil is a failure condition that panics if called with nil, acting as a strict regression guard.
panicOnNil := func(err error) bool {
if err == nil {
panic("failure condition must never be called with nil error")
}
return true
}

b, err := NewCircuit(nil, WithFailureCondition(panicOnNil))
require.NoError(t, err)

assert.NotPanics(t, func() {
_, _ = Wrap(b, noop)(t.Context(), noopInSuccess)
})
}

// maybeAssertPanic is a test-table helper to assert that a function panics or not, depending on the value of wantPanic.
func maybeAssertPanic(t *testing.T, f func(), wantPanic any) {
wrapped := assert.NotPanics
Expand Down