Skip to content

Comments

add yacht exercise#1423

Open
xavdid wants to merge 5 commits intoexercism:mainfrom
xavdid:add-yacht
Open

add yacht exercise#1423
xavdid wants to merge 5 commits intoexercism:mainfrom
xavdid:add-yacht

Conversation

@xavdid
Copy link

@xavdid xavdid commented Feb 2, 2024

Adds the yacht exercise. I copied the tests from the JS track and added my own TS implementation (which roughly mirrors my Elixir approach).

Most files were generated by configlet. Cleared in the PR in the forum.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2024

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Feb 2, 2024
@ErikSchierboom ErikSchierboom reopened this Feb 2, 2024
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let @SleeplessByte do the actual review of the TS code

xavdid and others added 2 commits February 2, 2024 09:01
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
@SleeplessByte
Copy link
Member

Blocked by #1427

@ErikSchierboom
Copy link
Member

@SleeplessByte I've merged main into this branch to unblock.

@xavdid
Copy link
Author

xavdid commented Feb 29, 2024

@SleeplessByte is there anything else I need to do on this?

@BNAndras
Copy link
Member

There's a newer merge conflict from when I added Conway's Game of Life last year.

The end of the exercises array should look like

      ...
      {
        "slug": "game-of-life",
        "name": "Conway's Game of Life",
        "uuid": "c338cbce-fad4-4de0-bf0d-4a90803a0fe9",
        "practices": [],
        "prerequisites": [],
        "difficulty": 2,
        "topics": ["arrays", "conditionals", "filtering", "games"]
      },
      {
        "slug": "yacht",
        "name": "Yacht",
        "uuid": "06ac7eed-1417-4510-b526-eb068af21ad9",
        "practices": [],
        "prerequisites": [],
        "difficulty": 4,
        "topics": ["arrays", "conditionals", "filtering", "games"]
      }
    ]

@SleeplessByte
Copy link
Member

@BNAndras if you want you can take this over, I'll co-author the commit for @xavdid

@BNAndras
Copy link
Member

Sure. I want to make sure they get recognition for their work.

@xavdid
Copy link
Author

xavdid commented Feb 16, 2026

I'm not too worried either way - I had forgotten about this 😅 Feel free to take it over!

@BNAndras BNAndras mentioned this pull request Feb 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants