Suggested reorder of tests for space-age#302
Open
AmyShackles wants to merge 1 commit intoexercism:mainfrom
Open
Suggested reorder of tests for space-age#302AmyShackles wants to merge 1 commit intoexercism:mainfrom
AmyShackles wants to merge 1 commit intoexercism:mainfrom
Conversation
Danger has errored[!] Invalid Generated by 🚫 Danger |
Member
I really like this. Sorry this took forever to look into -- I'll see if this can be merged as is, or needs to be updated; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observations:
In the event that the programmer has not implemented the necessary rounding, it is possible for them to be led to believe that they simply have a rounding error when it's possible that their algorithm for determining the age on other planets is fundamentally flawed.
Suggestion:
It might be beneficial to have the order of the expects flipped so that each planet test first tests the target planet and then additionally checks for the accurate Earth age.