prevent raw str leaking into ArgparseArg.type #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magdaaniol
changed the title
ines
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves handling of type hints that sometimes arrive as plain strings on Windows (e.g. "str", "Path") instead of Python types.
get_argis updated to normalizeparam_typewhen it is a string:If the string matches a known base type ("str", "int", "float", "Path"), it is mapped to the corresponding Python type.
Otherwise, the string is discarded (param_type = None), ensuring that only Type, ConverterType, or None reach ArgparseArg.type.
Related support forum ticket: https://support.prodi.gy/t/bug-report-loading-custom-recipe-raises-unsupported-type-for-dataset-str/7606