Repository navigation
Remove stale disabled flag when removing a pipeline component - #14070
Open
davrens101 wants to merge 1 commit into
Open
davrens101 wants to merge 1 commit into
davrens101 wants to merge 1 commit into
Conversation
Signed-off-by: davrens101 <davrens101@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14069.
Language.remove_pipepops the component from_componentsbefore checkingname in self.disabled. Thedisabledproperty only lists disabled names that are still present in_components, so the check is always false for the component being removed and its name is left behind in_disabled. Adding a new component with the same name then silently inherits the stale disabled state.This replaces the check with
self._disabled.discard(name), which removes the entry unconditionally (and is a no-op when the component wasn't disabled).Before:
After:
Added a regression test in
spacy/tests/pipeline/test_pipe_methods.pythat asserts the disabled flag is cleared on removal and that a re-added component runs. Verified the new test fails on the unpatchedlanguage.pyand passes with the fix; the fulltest_pipe_methods.pysuite (46 tests) passes.Checklist
spacyCLI.