extism-convert dependency: explicit features#84
Open
tannaurus wants to merge 1 commit intoextism:mainfrom
Open
extism-convert dependency: explicit features#84tannaurus wants to merge 1 commit intoextism:mainfrom
tannaurus wants to merge 1 commit intoextism:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extism-convert's default features (
msgpack, prost, raw) were always enabled because the dependency listed in rust-pdk didn't setdefault-features = falseThis change sets
default-features = falseon extism-convert and forwardsprostandrawthrough extism-pdk's own default features, preserving current behavior while allowing users to disable them withdefault-features = falseThis is technically a breaking change: consumers may depend on this bug by having
default-features = falsebut still relying on the types exposed byextism-convert::*