Skip to content

Conversation

@sbryzak
Copy link
Member

@sbryzak sbryzak commented Jun 1, 2017

Signed-off-by: Shane Bryzak [email protected]

@alexeykazakov
Copy link
Collaborator

+1 to have one readme.

@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?


`$ docker build --build-arg OPERATING_MODE=clustered --tag IMAGE_NAME .`

Note that, this docker image installs the certificate to securely talk to OpenShift Online.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this part might not be required anymore, we're currently testing it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean the certificate installation

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah.. this is why this PR is now conflicting. This section has been removed from the readme. But we still need to verify if it's really not needed anymore.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still needed to do it to test oAuth between KC and minishift, before installing the certificate my log was full of certificate-related errors and nothing worked.

To build this image it is necessary to have previously generated the executables of this
project. To do this, run the following Maven command in the almighty/keycloak repository:

`$ mvn clean install -DskipTests -pl :keycloak-server-dist -am -P distribution`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we are building the keycloak-server-dist, but if it is the first time you run this project. You need $ mvn clean install -DskipTests -am -P distribution

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a note as such in the readme.

@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?


In the content of the Dockerfile, you can find these ENV variables:
```
ENV OSO_ADDRESS tsrv.devshift.net:8443
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need certificate handling anymore

@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@alexeykazakov
Copy link
Collaborator

@sbryzak can you please update this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants