Follow relative imports in site_packages in gen_source_db#4
Open
msullivan wants to merge 1 commit intofacebook:mainfrom
Open
Follow relative imports in site_packages in gen_source_db#4msullivan wants to merge 1 commit intofacebook:mainfrom
msullivan wants to merge 1 commit intofacebook:mainfrom
Conversation
|
@brittanyrey has imported this pull request. If you are a Meta employee, you can view this in D101645305. |
brittanyrey
reviewed
Apr 20, 2026
Contributor
brittanyrey
left a comment
brittanyrey
left a comment
There was a problem hiding this comment.
Hmm, it looks like this PR pulls in foldhash as a Cargo.lock dep...
Contributor
|
the |
Contributor
Author
|
Sorry, the Cargo.lock changes get done automatically by |
msullivan
force-pushed
the
relative-imports
branch
from
ffe5a30 to
fcde874
Compare
brittanyrey
reviewed
Apr 21, 2026
brittanyrey
approved these changes
Apr 21, 2026
Contributor
Author
Contributor
|
#6 looks great to me, we can wait till that goes in and then rebase and land this one |
msullivan
force-pushed
the
relative-imports
branch
2 times, most recently
from
5ffbf70 to
02d286c
Compare
When processing modules in site_packages, track the current package and use that to resolve relative imports. We don't bother doing this for packages in the project because they are currently all collected.
msullivan
force-pushed
the
relative-imports
branch
from
02d286c to
0d573d4
Compare
Contributor
Author
|
Alright I think this is all good and rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When processing modules in site_packages, track the current package
and use that to resolve relative imports.
We don't bother doing this for packages in the project because they
are currently all collected.