fix(core): optimize i18n integration for site builds + improve inference of locale config #11550
+116
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do not call loadContext just to retrieve the list of locales to build
…to support cases where the locale name is not BCP 47
slorber
added
pr: bug fix
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: +276 B (0%) Total Size: 11.8 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: +266 B (0%) Total Size: 12.2 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Previously, when running
docusaurus build, we called the siteloadContext()method twice (or more):This is annoying because this is not optimal: we don't need to call
loadContext()just to get the list of locales to build. I simplified that code path so that we do not need to run things we will throw away later.This is particularly important for the VCS integration, because for now, I decided to put the VCS init code inside the
loadContext()method, and I noticed the VCS init ran twice for no reason. See #11512I also took the opportunity to improve the locale config inference a bit, since I noticed a little issue that prevents inference from working in this specific config case. The following will now work (because
'en-US'is a valid BCP 47 name) while it previously throwed:Test Plan
Unit tests + CI