Start replacing GCScope with Locals in JSLib #1719
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76012420 |
Summary: Make sure all new handle allocations happen through `makeHandle()` calls instead of directly calling `Handle` allocating constructors. Differential Revision: D76012421
Summary: Instead of the temporary handle, use Locals. Differential Revision: D76012419
Summary: - Make it copyable. It is extremely annoying otherwise. - Add castAndSetHermesValue() Differential Revision: D76012422
Summary: Pull Request resolved: facebook#1719 This diff only adds locals, doesn't remove GCScope yet. Reviewed By: avp Differential Revision: D76012420
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76012420 |
tmikov
force-pushed
the
export-D76012420-to-static_h
branch
from
0011ca3 to
5db92ef
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 12, 2025
Summary: Pull Request resolved: #1719 This diff only adds locals, doesn't remove GCScope yet. Reviewed By: avp Differential Revision: D76012420 fbshipit-source-id: f356223a4ee21a7d835dd0e593b9f984c6c822b7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff only adds locals, doesn't remove GCScope yet.
Reviewed By: avp
Differential Revision: D76012420