anti-inflaction act #177
Open
anti-inflaction act #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
automatically detects when compressing a chunk expands rather than contract space. Replace it by a STORE operation in this case, reducing the overhead and decompression time. This is also useful to better control worst case expansion, which has a direct impact on compressBound(). Note: it will be possible to tighten compressBound() after this patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a verification at the production of each Chunk,
which kicks in whenever the Graph has expanded instead of contracted original data
and replaces it by
STORE.This in turns makes OpenZL's
compressBound()much more predictable.A future update could tighten it.