Merged
Conversation
Contributor
|
Thanks, @fabriziobertoglio1987. Question for you and maybe also @cortinico — When should I publish a major release for this package that incorporates these changes? I'm thinking we may want to do one release that includes any other changes that will go out in the next React Native release. |
Contributor
Author
|
@yungsters Today, I will review all my previously merged PRs and verify if other changes are required. This PR reverts the changes introduced with #15 (merged in the main three weeks ago). Does not add any new changes to the existing functionalities. PR #17 is in DRAFT, and it may introduce a new prop type (accessibilitySpan).
Thanks a lot.🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reverts the changes to accessibilityRoles. The original PR is under review facebook/react-native#35130
based on comment facebook/react-native#35130 (comment), the prop accessibilitySpan was separated from accessibilityRole
Related #15