[LOCAL] Copy hermes ruby files to hermes folder in local E2E test#39577
Merged
cipolleschi merged 1 commit into0.71-stablefrom Sep 22, 2023
Merged
Conversation
facebook-github-bot
added
the
CLA Signed
cipolleschi
deleted the
cipolleschi/fix_071_local_e2e_script_copy_herme_engine_ruby_files
branch
Merged
This was referenced Jan 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When testing another feature, I realized that we were not copying the
hermes-engine.podspecand thehermes-utils.rbfiles from thehermes-enginefolder to thehermesone.This means that the script was building Hermes for local testing using an outdated
hermes-engine.podspecthat is downloaded from thehermesrepo.Changelog:
[INTERNAL] - Copy over the
hermes-engine.podspecandhermes-utils.rbfiles in thetest-e2e-localscriptTest Plan:
Tested locally