-
Notifications
You must be signed in to change notification settings - Fork 50.2k
Add ReactChildren test for single-child key patterns #35400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @afurm! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
thanks for explaining how this is handled
…On Sun, Dec 21, 2025 at 5:08 PM meta-cla[bot] ***@***.***> wrote:
*meta-cla[bot]* left a comment (facebook/react#35400)
<#35400 (comment)>
Thank you for signing our Contributor License Agreement. We can now accept
your code for this (and any) Meta Open Source project. Thanks!
—
Reply to this email directly, view it on GitHub
<#35400 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/B3Z3TW2BULBQOB23VIWQ6LD4C3HXRAVCNFSM6AAAAACPV42QDGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMNZZGA4TOMJWGA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
got it thanks for the confirmation
…On Sun, Dec 21, 2025 at 5:05 PM Andrii Furmanets ***@***.***> wrote:
What
- Add a test to verify React.Children.map uses the same key pattern
for a single child and an array with one item, for both keyed and unkeyed
inputs.
Why
- Covers the TODO near escape() in packages/react/src/ReactChildren.js
and guards against regressions in key normalization.
Notes
- Tests not run (not requested).
Checklist
- Tests run
- Docs updated (not needed)
------------------------------
You can view, comment on, or merge this pull request online at:
#35400
Commit Summary
- 1be3a3a
<1be3a3a>
Add test for single-child key patterns
File Changes
(1 file <https://github.com/facebook/react/pull/35400/files>)
- *M* packages/react/src/__tests__/ReactChildren-test.js
<https://github.com/facebook/react/pull/35400/files#diff-e07e1ca8de0b8a02a3a600bdf855e7d8a46d6eae2d291cfa02df54c7d5abf3a2>
(34)
Patch Links:
- https://github.com/facebook/react/pull/35400.patch
- https://github.com/facebook/react/pull/35400.diff
—
Reply to this email directly, view it on GitHub
<#35400>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/B3Z3TZL5MEYSXMFSIGSYF434C3HPHAVCNFSM6AAAAACPV42QDGVHI2DSMVQWIX3LMV43ASLTON2WKOZTG42TCMZVGIZTIMA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
thanks for the update on this
…On Sun, Dec 21, 2025 at 5:05 PM Andrii Furmanets ***@***.***> wrote:
What
- Add a test to verify React.Children.map uses the same key pattern
for a single child and an array with one item, for both keyed and unkeyed
inputs.
Why
- Covers the TODO near escape() in packages/react/src/ReactChildren.js
and guards against regressions in key normalization.
Notes
- Tests not run (not requested).
Checklist
- Tests run
- Docs updated (not needed)
------------------------------
You can view, comment on, or merge this pull request online at:
#35400
Commit Summary
- 1be3a3a
<1be3a3a>
Add test for single-child key patterns
File Changes
(1 file <https://github.com/facebook/react/pull/35400/files>)
- *M* packages/react/src/__tests__/ReactChildren-test.js
<https://github.com/facebook/react/pull/35400/files#diff-e07e1ca8de0b8a02a3a600bdf855e7d8a46d6eae2d291cfa02df54c7d5abf3a2>
(34)
Patch Links:
- https://github.com/facebook/react/pull/35400.patch
- https://github.com/facebook/react/pull/35400.diff
—
Reply to this email directly, view it on GitHub
<#35400>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/B3Z3T2M2LZFGWIILTDKLWZT4C3HPHAVCNFSM6AAAAACPV42QDGVHI2DSMVQWIX3LMV43ASLTON2WKOZTG42TCMZVGIZTIMA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
What
React.Children.mapuses the same key pattern for a single child and an array with one item, for both keyed and unkeyed inputs.Why
escape()inpackages/react/src/ReactChildren.jsand guards against regressions in key normalization.Notes
Checklist