Skip to content

Conversation

@afurm
Copy link

@afurm afurm commented Dec 21, 2025

What

  • Add a test to verify React.Children.map uses the same key pattern for a single child and an array with one item, for both keyed and unkeyed inputs.

Why

  • Covers the TODO near escape() in packages/react/src/ReactChildren.js and guards against regressions in key normalization.

Notes

  • Tests not run (not requested).

Checklist

  • Tests run
  • Docs updated (not needed)

@meta-cla
Copy link

meta-cla bot commented Dec 21, 2025

Hi @afurm!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@meta-cla
Copy link

meta-cla bot commented Dec 21, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed label Dec 21, 2025
@jaefulcherh68-dev
Copy link

jaefulcherh68-dev commented Dec 21, 2025 via email

@rgftblanchefitzgeraldjoseph67-dev
Copy link

@loshihehfhdf-ship-it
Copy link

loshihehfhdf-ship-it commented Dec 21, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants