Skip to content

Return -1 from the unreachable default case in seek_buff #4763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
afonsojanu wants to merge 1 commit into from
Closed

Return -1 from the unreachable default case in seek_buff #4763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions contrib/seekable_format/tests/seekable_tests.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ static int seekBuffWithTotal(void* opaque, long long offset, int origin)
break;
default:
assert(0); /* not possible */
return -1; /* keeps newOffset from being read uninitialised when NDEBUG strips the assert */
}
if (newOffset > buff->size) {
return -1;
Expand Down
1 change: 1 addition & 0 deletions contrib/seekable_format/zstdseek_decompress.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@ static int ZSTD_seekable_seek_buff(void* opaque, long long offset, int origin)
break;
default:
assert(0); /* not possible */
return -1; /* keeps newOffset from being read uninitialised when NDEBUG strips the assert */
}
if (newOffset > buff->size) {
return -1;
Expand Down