Skip to content

Conversation

@ccotter
Copy link
Contributor

@ccotter ccotter commented Aug 5, 2024

examples/linux/http_server_io_uring_test.cpp: In function 'unifex::task<{anonymous}::Request> {anonymous}::parse_request(unifex::linuxos::io_uring_context::async_read_write_file&)':
examples/linux/http_server_io_uring_test.cpp:99:34: error: format '%ld' expects argument of type 'long int', but argument 2 has type 'std::basic_string<char>::size_type' {aka 'unsigned int'} [-Werror=format=]
   99 |       std::printf("req too big=%ld\n", req.size());
      |                                ~~^     ~~~~~~~~~~
      |                                  |             |
      |                                  long int      std::basic_string<char>::size_type {aka unsigned int}
      |                                %d
examples/linux/http_server_io_uring_test.cpp: In lambda function:
examples/linux/http_server_io_uring_test.cpp:160:54: error: format '%ld' expects argument of type 'long int', but argument 2 has type 'std::chrono::duration<long long int, std::ratio<1, 1000> >::rep' {aka 'long long int'} [-Werror=format=]
  160 |             then([ms] { std::printf("Timeout after %ldms\n", ms.count()); }),
      |                                                    ~~^       ~~~~~~~~~~
      |                                                      |               |
      |                                                      long int        std::chrono::duration<long long int, std::ratio<1, 1000> >::rep {aka long long int}
      |                                                    %lld

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 5, 2024
Copy link
Contributor

@ispeters ispeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I like the intent and want to merge it, but it seems there are some broken CI jobs that'll need fixing first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants