Skip to content

Conversation

@karthik-man
Copy link
Contributor

FB-only:

This PR will be imported to fbcode diff. Ensure all internal tests passed.

For TLX, run third_party/tlx/run_all.sh to cover TLX unit tests and TLX kernel correctness verification:

Need to build triton in this script? {y|n}n
Run all LITs? {y|n}n
Run core Triton python unit tests? {y|n}n
Run all TLX unit tests? {y|n}y
Running TLX Unit Tests
...
Run TLX tutorial kernels (correctness|performance|no)? {c|p|n}c
...

New contributor declaration (copied from Core Triton):

  • I am not making a trivial change, such as fixing a typo in a comment.

  • I have written a PR description following these
    rules.

  • I have run pre-commit run --from-ref origin/main --to-ref HEAD.

  • Select one of the following.

    • I have added tests.
      • /test for lit tests
      • /unittest for C++ tests
      • /python/test for end-to-end tests
    • This PR does not need a test because FILL THIS IN.
  • Select one of the following.

    • I have not added any lit tests.
    • The lit tests I have added follow these best practices,
      including the "tests should be minimal" section. (Usually running Python code
      and using the instructions it generates is not minimal.)

[tlx-dsm] test: rewrite to use BLOCK_N

[tlx-dsm] test: rewrite to use BLOCK_N

[tlx-dsm] propogate num reduction-ctas

Fixed grid issues. N//2 pass on multi-cta-reduce.py

fails with illegal instruction, maybe CSE is removing one store

crashes with illegal instruction

Works after hard-coding ctaRank=0 in LocalStoreOpConversion

Benchmarks (using 2 cta hard coding)
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 21, 2025
@meta-codesync
Copy link

meta-codesync bot commented Nov 21, 2025

@karthik-man has imported this pull request. If you are a Meta employee, you can view this in D87662281.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant