-
Notifications
You must be signed in to change notification settings - Fork 46
Add ttpforge validate command #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
isaac-fletcher
wants to merge
1
commit into
facebookincubator:main
Choose a base branch
from
isaac-fletcher:export-D85961391
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add ttpforge validate command #574
isaac-fletcher
wants to merge
1
commit into
facebookincubator:main
from
isaac-fletcher:export-D85961391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@isaac-fletcher has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85961391. |
isaac-fletcher
added a commit
to isaac-fletcher/TTPForge
that referenced
this pull request
Nov 12, 2025
Summary: Pull Request resolved: facebookincubator#574 Implemented a new `validate` command for TTPForge that performs comprehensive static analysis and validation of TTP YAML files. This command helps ensure TTPs are correctly structured before execution. The validator performs multiple types of checks: - Structural validation (required fields, data types, YAML syntax) - Preamble field validation (api_version, uuid, name) - Step action validation (ensures required fields for each action type) - Template variable detection and handling - Integration with blocks package for runtime validation The command supports single-file validation, with colored output for errors (red), warnings (yellow), and informational messages (blue). Template-based TTPs are handled gracefully with appropriate warnings when full validation requires runtime arguments. Reviewed By: d0n601 Differential Revision: D85961391
0681706 to
9ba4dce
Compare
isaac-fletcher
added a commit
to isaac-fletcher/TTPForge
that referenced
this pull request
Nov 17, 2025
Summary: Pull Request resolved: facebookincubator#574 Implemented a new `validate` command for TTPForge that performs comprehensive static analysis and validation of TTP YAML files. This command helps ensure TTPs are correctly structured before execution. The validator performs multiple types of checks: - Structural validation (required fields, data types, YAML syntax) - Preamble field validation (api_version, uuid, name) - Step action validation (ensures required fields for each action type) - Template variable detection and handling - Integration with blocks package for runtime validation The command supports single-file validation, with colored output for errors (red), warnings (yellow), and informational messages (blue). Template-based TTPs are handled gracefully with appropriate warnings when full validation requires runtime arguments. Reviewed By: d0n601 Differential Revision: D85961391
9ba4dce to
b305ff0
Compare
isaac-fletcher
added a commit
to isaac-fletcher/TTPForge
that referenced
this pull request
Nov 17, 2025
Summary: Pull Request resolved: facebookincubator#574 Implemented a new `validate` command for TTPForge that performs comprehensive static analysis and validation of TTP YAML files. This command helps ensure TTPs are correctly structured before execution. The validator performs multiple types of checks: - Structural validation (required fields, data types, YAML syntax) - Preamble field validation (api_version, uuid, name) - Step action validation (ensures required fields for each action type) - Template variable detection and handling - Integration with blocks package for runtime validation The command supports single-file validation, with colored output for errors (red), warnings (yellow), and informational messages (blue). Template-based TTPs are handled gracefully with appropriate warnings when full validation requires runtime arguments. Reviewed By: d0n601 Differential Revision: D85961391
b305ff0 to
131beef
Compare
Summary: Pull Request resolved: facebookincubator#574 Implemented a new `validate` command for TTPForge that performs comprehensive static analysis and validation of TTP YAML files. This command helps ensure TTPs are correctly structured before execution. The validator performs multiple types of checks: - Structural validation (required fields, data types, YAML syntax) - Preamble field validation (api_version, uuid, name) - Step action validation (ensures required fields for each action type) - Template variable detection and handling - Integration with blocks package for runtime validation The command supports single-file validation, with colored output for errors (red), warnings (yellow), and informational messages (blue). Template-based TTPs are handled gracefully with appropriate warnings when full validation requires runtime arguments. Reviewed By: d0n601 Differential Revision: D85961391
131beef to
f1592fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Implemented a new
validatecommand for TTPForge that performs comprehensive static analysis and validation of TTP YAML files. This command helps ensure TTPs are correctly structured before execution.The validator performs multiple types of checks:
The command supports single-file validation, with colored output for errors (red), warnings (yellow), and informational messages (blue). Template-based TTPs are handled gracefully with appropriate warnings when full validation requires runtime arguments.
Reviewed By: d0n601
Differential Revision: D85961391