fix: Allow building with VELOX_MONO_LIBRARY #385
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
…velox_link_libraries
…s build as mono library
MBkkt
force-pushed
the
mbkkt/worse-fix-cmake
branch
from
209817b to
375b80b
Compare
mbasmanova
reviewed
Sep 10, 2025
| target_link_libraries( | ||
| velox_hive_connector_metadata_test | ||
| velox_hive_connector_metadata | ||
| axiom_hive_connector_metadata_test |
Contributor
There was a problem hiding this comment.
I like these new names. Would it be possible to extract renaming make targets into a separate PR?
Collaborator
Author
mbasmanova
changed the title
Collaborator
Author
|
I don't need this in this way, so close it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mbasmanova I copied PR #375 and applied @assignUser suggestion to make cmake "modern".
Unfortunately such solution is worse in terms of produced binaries and usability for us in serenedb, but even in such case it's still better than current main.