fix: Make sameOrEqual work properly #561
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
pashandor789
changed the title
Contributor
Author
|
@mbasmanova hey! have found a bug and fixed it |
mbasmanova
reviewed
Oct 25, 2025
Contributor
mbasmanova
left a comment
mbasmanova
left a comment
There was a problem hiding this comment.
@pashandor789 Thank you for the fix. Would you add a test?
Contributor
|
CI is red. |
pashandor789
changed the title
pashandor789
changed the title
pashandor789
changed the title
Collaborator
|
@mbasmanova CI is green now |
Contributor
Author
|
@mbasmanova i'm really not sure how to test it. It's used in the depths of the optimizer. Is it possible to merge without test because the fix is really obviuos, WDYT? 🤔 |
Contributor
This logic is unit testable, no? |
Collaborator
|
@mbasmanova Yes, I even did this, but not sure it's helpful. I think this code actually couldn't be called while we don't have data sources with partitionkeys/orderkeys that isn't just columns. I think it's possible in theory but in practice we don't have such usage right now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a logical error in the
Expr::sameOrEqualmethod inQueryGraph.cpp. The change corrects the condition for comparing arguments in function call expressions.Expr::sameOrEqualso that it returnsfalseif any argument is not the same or equal, rather than if any argument is the same or equal.