fix: Change flattenDt to account DerivedTable properties #579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
MBkkt
changed the title
MBkkt
changed the title
MBkkt
force-pushed
the
mbkkt/find-more-bugs
branch
from
d5ae36a to
e80b6e9
Compare
MBkkt
changed the title
MBkkt
force-pushed
the
mbkkt/find-more-bugs
branch
from
e80b6e9 to
a0958ae
Compare
I saw Orri commit, I don't think it's fix all issues. Lets check for all fields that it's equal or we account it in a some way. We will found for an example that cardinality is missed :( I think some other fields also doesn't work
MBkkt
force-pushed
the
mbkkt/find-more-bugs
branch
from
a0958ae to
b12792f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know how to test this, but I saw similar changes in Orri commit and thinks there's more issues.
Also cardinality and some other fields (joinedBy/startTables) didn't assign now