Make cpp/wrap.h header only #102
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is used by some C++-only libraries and binaries (e.g., the C++ indexer) which we don't really want to depend on Haskell libs. We should probably move the C++ FFI bits into a separate lib but making it header-only for now is easy and might be the right thing to do anyway (the address comparisons we used to do might actually be dodgy with dynamic linking).
facebook-github-bot
added
the
CLA Signed
rleshchinskiy
added a commit
to rleshchinskiy/Glean
that referenced
this pull request
Sep 11, 2022
This should be landed together with facebookincubator/hsthrift#102 which removes ffi.h from fb-util
Contributor
Author
|
This should be landed together with facebookincubator/Glean#269 which tracks the change in Glean. |
rleshchinskiy
added a commit
to rleshchinskiy/Glean
that referenced
this pull request
Sep 12, 2022
This should be landed together with facebookincubator/hsthrift#102 which removes ffi.h from fb-util
facebook-github-bot
pushed a commit
to facebookincubator/Glean
that referenced
this pull request
Sep 13, 2022
Summary: This should be landed together with facebookincubator/hsthrift#102 which removes ffi.h from fb-util Pull Request resolved: #269 Reviewed By: nhawkes Differential Revision: D39420793 Pulled By: donsbot fbshipit-source-id: 8a753d05f7c483bbab26c82ef23d42ba59b3c4f1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is used by some C++-only libraries and binaries (e.g., the C++ indexer) which we don't really want to depend on Haskell libs. We should probably move the C++ FFI bits into a separate lib but making it header-only for now is easy and might be the right thing to do anyway (the address comparisons we used to do might actually be dodgy with dynamic linking).