perf: Reserve space for holders_ in DecodedArgs constructor #15418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
ttsugriy
force-pushed
the
export-D86366246
branch
from
96394d5 to
e98b390
Compare
ttsugriy
added a commit
to ttsugriy/velox
that referenced
this pull request
Nov 6, 2025
…tor#15418) Summary: The DecodedArgs constructor was populating the holders_ vector without pre-allocating space, which could cause multiple reallocations as the vector grows. This adds a reserve() call before the loop to allocate space upfront for all elements, improving performance by avoiding unnecessary allocations and copies. Differential Revision: D86366246
ttsugriy
added a commit
to ttsugriy/velox
that referenced
this pull request
Nov 6, 2025
…incubator#15418) Summary: The DecodedArgs constructor was populating the holders_ vector without pre-allocating space, which could cause multiple reallocations as the vector grows. This adds a reserve() call before the loop to allocate space upfront for all elements, improving performance by avoiding unnecessary allocations and copies. Differential Revision: D86366246
ttsugriy
force-pushed
the
export-D86366246
branch
2 times, most recently
from
c8aa1dd to
48ff7c2
Compare
ttsugriy
added a commit
to ttsugriy/velox
that referenced
this pull request
Nov 9, 2025
…incubator#15418) Summary: The DecodedArgs constructor was populating the holders_ vector without pre-allocating space, which could cause multiple reallocations as the vector grows. This adds a reserve() call before the loop to allocate space upfront for all elements, improving performance by avoiding unnecessary allocations and copies. Differential Revision: D86366246
Yuhta
approved these changes
Nov 12, 2025
ttsugriy
force-pushed
the
export-D86366246
branch
from
ed07c39 to
a3a3aac
Compare
ttsugriy
added a commit
to ttsugriy/velox
that referenced
this pull request
Nov 13, 2025
…incubator#15418) Summary: The DecodedArgs constructor was populating the holders_ vector without pre-allocating space, which could cause multiple reallocations as the vector grows. This adds a reserve() call before the loop to allocate space upfront for all elements, improving performance by avoiding unnecessary allocations and copies. Reviewed By: Yuhta Differential Revision: D86366246
ttsugriy
changed the title
…incubator#15418) Summary: The DecodedArgs constructor was populating the holders_ vector without pre-allocating space, which could cause multiple reallocations as the vector grows. This adds a reserve() call before the loop to allocate space upfront for all elements, improving performance by avoiding unnecessary allocations and copies. Reviewed By: Yuhta Differential Revision: D86366246
ttsugriy
force-pushed
the
export-D86366246
branch
from
a3a3aac to
35c20a7
Compare
|
This pull request has been merged in 646ea2a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The DecodedArgs constructor was populating the holders_ vector without
pre-allocating space, which could cause multiple reallocations as the
vector grows. This adds a reserve() call before the loop to allocate
space upfront for all elements, improving performance by avoiding
unnecessary allocations and copies.
Differential Revision: D86366246