Add Time with Timezone to at_timezone function #15435
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
|
@natashasehgal has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86487936. |
Contributor
|
Thanks for this change @natashasehgal ! |
kgpai
reviewed
Nov 7, 2025
|
|
||
| // Similar to timestamp version - only timezone ID changes, not the time | ||
| // value. | ||
| result = pack(inputMs, targetTimezoneID); |
Contributor
There was a problem hiding this comment.
I think you need to call the time equivalent of time with timezone else you will create invalid time types.
| struct AtTimezoneTimeFunction : public TimestampWithTimezoneSupport<T> { | ||
| VELOX_DEFINE_FUNCTION_TYPES(T); | ||
|
|
||
| std::optional<int64_t> targetTimezoneID_; |
Contributor
There was a problem hiding this comment.
This need only be an int16_t type..
| at_timezone_time( | ||
| pack(millisTenOClockWarsawWinter, tz::getTimeZoneID("Europe/Warsaw")), | ||
| "UTC"), | ||
| pack(millisTenOClockWarsawWinter, tz::getTimeZoneID("UTC"))); |
Contributor
There was a problem hiding this comment.
This isnt right, timewithtimezone supports bias encoding of offset minutes, not IANA timezone id's.
Summary: Add Time with Timezone to at_timezone function Found usage within Meta, this is available on Presto not velox -> Scalar function presto.default.at_timezone not registered with arguments: (TIME WITH TIME ZONE, VARCHAR) Differential Revision: D86487936
natashasehgal
force-pushed
the
export-D86487936
branch
from
d15b89e to
1425cf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add Time with Timezone to at_timezone function
Found usage within Meta, this is available on Presto not velox ->
Scalar function presto.default.at_timezone not registered with arguments: (TIME WITH TIME ZONE, VARCHAR)
Differential Revision: D86487936