deser: Skip unnecessary clone step in loadTensor #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@excelle08 has imported this pull request. If you are a Meta employee, you can view this in D84159390. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The copy assignment operator results into a clone of the input IOBuffer (
cloneAsValue), which is followed by a coalesce operation on the previously cloned buffer (coalesceWithHeadroomTailroom).Both operations can be combined by calling
cloneCoalescedAsValueWithHeadroomTailroominstead, which gives a measurable speedup due to reduced overhead of the clone operation. On an aarch64 system, I measured a 17% speedup with 72 worker threads for thedeser_ainput.