Skip to content

Commit f005f9c

Browse files
cdtwiggfacebook-github-bot
authored andcommitted
Rename from_gltf_bytes_with_motion to load_gltf_with_motion_from_bytes (#568)
Summary: Pull Request resolved: #568 This was actually feedback when I first landed this function, but I never got around to it. However I recently noticed that there's a ton of inconsistency across these IO functions so let's unify them. This is the second in a series of changes to make IO function naming more consistent across pymomentum. The naming pattern we're following is: {action}_{format}[_{data_type}][_{source_type}] Reviewed By: jeongseok-meta Differential Revision: D82386793 fbshipit-source-id: 76e6a0a947e76f60b05a7b251b50b24dddbd94c7
1 parent 80abdd2 commit f005f9c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

pymomentum/geometry/geometry_pybind.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -678,10 +678,10 @@ Note: In practice, most limits are enforced on the model parameters, but momentu
678678
)",
679679
py::arg("gltf_bytes"))
680680
.def_static(
681-
"from_gltf_bytes_with_motion",
681+
"load_gltf_with_motion_from_bytes",
682682
&loadGLTFCharacterWithMotionFromBytes,
683683
py::call_guard<py::gil_scoped_release>(),
684-
R"(Load a character from a gltf byte array.
684+
R"(Load a character and motion from a gltf byte array.
685685
686686
:param gltf_bytes: A :class:`bytes` containing the GLTF JSON/messagepack data.
687687
:return: a valid :class:`Character`.

0 commit comments

Comments
 (0)