Refactor to remove duplicate code in marker_tracking. #609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
cdtwigg
added a commit
that referenced
this pull request
Oct 7, 2025
Summary: We have two functions, trackPosesPerframe and trackPosesForFrames, which are largely identical. This kept messing me up because I would add functionality in one of the functions or the other and then be confused why nothing had changed. Looking at the two functions, they perform the same function, we just need to pass in the appropriate set of frames into trackPosesForFrames and add support for temporal coherence. Reviewed By: jeongseok-meta Differential Revision: D82688034
cdtwigg
force-pushed
the
export-D82688034
branch
from
d869a04 to
f08b507
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 5, 2025
Summary: We have two functions, trackPosesPerframe and trackPosesForFrames, which are largely identical. This kept messing me up because I would add functionality in one of the functions or the other and then be confused why nothing had changed. Looking at the two functions, they perform the same function, we just need to pass in the appropriate set of frames into trackPosesForFrames and add support for temporal coherence. Reviewed By: jeongseok-meta Differential Revision: D82688034
facebook-github-bot
force-pushed
the
export-D82688034
branch
from
f08b507 to
29cbddc
Compare
facebook-github-bot
temporarily deployed
to
pypi-cpu
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
pypi-cpu
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
pypi-gpu
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
pypi-gpu
GitHub Actions
Inactive
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 5, 2025
Summary: We have two functions, trackPosesPerframe and trackPosesForFrames, which are largely identical. This kept messing me up because I would add functionality in one of the functions or the other and then be confused why nothing had changed. Looking at the two functions, they perform the same function, we just need to pass in the appropriate set of frames into trackPosesForFrames and add support for temporal coherence. Reviewed By: jeongseok-meta Differential Revision: D82688034
facebook-github-bot
force-pushed
the
export-D82688034
branch
from
29cbddc to
fc9d5e8
Compare
facebook-github-bot
temporarily deployed
to
pypi-cpu
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
pypi-cpu
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
pypi-gpu
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
pypi-gpu
GitHub Actions
Inactive
cdtwigg
added a commit
that referenced
this pull request
Nov 5, 2025
Summary: Pull Request resolved: #609 We have two functions, trackPosesPerframe and trackPosesForFrames, which are largely identical. This kept messing me up because I would add functionality in one of the functions or the other and then be confused why nothing had changed. Looking at the two functions, they perform the same function, we just need to pass in the appropriate set of frames into trackPosesForFrames and add support for temporal coherence. Reviewed By: cstollmeta, jeongseok-meta Differential Revision: D82688034
cdtwigg
force-pushed
the
export-D82688034
branch
from
fc9d5e8 to
7022322
Compare
Contributor
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 10, 2025
Summary: We have two functions, trackPosesPerframe and trackPosesForFrames, which are largely identical. This kept messing me up because I would add functionality in one of the functions or the other and then be confused why nothing had changed. Looking at the two functions, they perform the same function, we just need to pass in the appropriate set of frames into trackPosesForFrames and add support for temporal coherence. Reviewed By: cstollmeta, jeongseok-meta Differential Revision: D82688034
facebook-github-bot
force-pushed
the
export-D82688034
branch
from
7022322 to
f8ea248
Compare
Summary: I find myself wanting to add text labels to things in the image, currently the only way to do that is to fork out to OpenCV. It would be neat if we could write text to the image but support z-buffer checking, and if we didn't have to fork out to a separate library. Reviewed By: jeongseok-meta, cstollmeta Differential Revision: D85690037
Summary: We have two functions, trackPosesPerframe and trackPosesForFrames, which are largely identical. This kept messing me up because I would add functionality in one of the functions or the other and then be confused why nothing had changed. Looking at the two functions, they perform the same function, we just need to pass in the appropriate set of frames into trackPosesForFrames and add support for temporal coherence. Reviewed By: cstollmeta, jeongseok-meta Differential Revision: D82688034
facebook-github-bot
force-pushed
the
export-D82688034
branch
from
f8ea248 to
c96c60f
Compare
facebook-github-bot
temporarily deployed
to
pypi-cpu
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
pypi-gpu
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
pypi-cpu
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
pypi-gpu
GitHub Actions
Inactive
Contributor
|
This pull request has been merged in 6195b6e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We have two functions, trackPosesPerframe and trackPosesForFrames, which are largely identical. This kept messing me up because I would add functionality in one of the functions or the other and then be confused why nothing had changed.
Looking at the two functions, they perform the same function, we just need to pass in the appropriate set of frames into trackPosesForFrames and add support for temporal coherence.
Reviewed By: jeongseok-meta
Differential Revision: D82688034