Add tests to python binding #752
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 30, 2025
Summary: Pull Request resolved: #752 Differential Revision: D85739418
facebook-github-bot
force-pushed
the
export-D85739418
branch
2 times, most recently
from
aa1b742 to
fc988e5
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 30, 2025
Summary: Add python tests for marker sequence io in fbx and the unified save function. Differential Revision: D85739418
facebook-github-bot
temporarily deployed
to
pypi-cpu
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
pypi-gpu
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
pypi-gpu
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
pypi-cpu
GitHub Actions
Inactive
yutingye
force-pushed
the
export-D85739418
branch
from
fc988e5 to
23d36a6
Compare
yutingye
added a commit
that referenced
this pull request
Oct 30, 2025
Summary: Add python tests for marker sequence io in fbx and the unified save function. Differential Revision: D85739418
yutingye
added a commit
that referenced
this pull request
Nov 1, 2025
Summary: Pull Request resolved: #752 Add python tests for marker sequence io in fbx and the unified save function. Reviewed By: jeongseok-meta Differential Revision: D85739418
yutingye
force-pushed
the
export-D85739418
branch
from
23d36a6 to
a6d5a0a
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 1, 2025
Summary: Add python tests for marker sequence io in fbx and the unified save function. Reviewed By: jeongseok-meta Differential Revision: D85739418
yutingye
added a commit
that referenced
this pull request
Nov 2, 2025
Summary: Add python tests for marker sequence io in fbx and the unified save function. Reviewed By: jeongseok-meta Differential Revision: D85739418
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 2, 2025
Summary: Add python tests for marker sequence io in fbx and the unified save function. Reviewed By: jeongseok-meta Differential Revision: D85739418
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 2, 2025
Summary: Add python tests for marker sequence io in fbx and the unified save function. Reviewed By: jeongseok-meta Differential Revision: D85739418
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 2, 2025
Summary: Add python tests for marker sequence io in fbx and the unified save function. Reviewed By: jeongseok-meta Differential Revision: D85739418
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 3, 2025
Summary: Add python tests for marker sequence io in fbx and the unified save function. Reviewed By: jeongseok-meta Differential Revision: D85739418
facebook-github-bot
force-pushed
the
export-D85739418
branch
from
a6d5a0a to
981b7ee
Compare
yutingye
added a commit
that referenced
this pull request
Nov 3, 2025
Summary: Pull Request resolved: #752 Add python tests for marker sequence io in fbx and the unified save function. Reviewed By: jeongseok-meta Differential Revision: D85739418
yutingye
added a commit
that referenced
this pull request
Nov 3, 2025
Summary: Pull Request resolved: #752 Add python tests for marker sequence io in fbx and the unified save function. Reviewed By: jeongseok-meta Differential Revision: D85739418
yutingye
added a commit
that referenced
this pull request
Nov 3, 2025
Summary: Pull Request resolved: #752 Add python tests for marker sequence io in fbx and the unified save function. Reviewed By: jeongseok-meta Differential Revision: D85739418
yutingye
added a commit
that referenced
this pull request
Nov 3, 2025
Summary: Pull Request resolved: #752 Add python tests for marker sequence io in fbx and the unified save function. Reviewed By: jeongseok-meta Differential Revision: D85739418
yutingye
added a commit
that referenced
this pull request
Nov 3, 2025
Summary: Pull Request resolved: #752 Add python tests for marker sequence io in fbx and the unified save function. Reviewed By: jeongseok-meta Differential Revision: D85739418
facebook-github-bot
temporarily deployed
to
pypi-cpu
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
pypi-cpu
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
pypi-gpu
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
pypi-gpu
GitHub Actions
Inactive
Summary: After D85530152 added marker sequence support to fbx, we have functionality parity between fbx and gltf. This diff created a unified `saveCharacter()` function in `character_io` that automatically selects between FBX and GLTF export based on file extension. Added .fbx support to `loadMarkers()` as the unified function for loading marker data from any supported format. Added an additional unified `saveCharacter()` function in `character_io` that takes skeleton states as input instead of model parameters. Rename `saveCharacter()` in `gltf_io` to `saveGltfCharacter()`, but keeping the existing ones for backwards compatibility for now. It will be removed in a later diff when downstreams are updated. Differential Revision: D85517572
Summary: Add python tests for marker sequence io in fbx and the unified save function. Reviewed By: jeongseok-meta Differential Revision: D85739418
facebook-github-bot
force-pushed
the
export-D85739418
branch
from
981b7ee to
35fc691
Compare
yutingye
added a commit
that referenced
this pull request
Nov 8, 2025
Summary: Pull Request resolved: #752 Add python tests for marker sequence io in fbx and the unified save function. Reviewed By: jeongseok-meta Differential Revision: D85739418
yutingye
added a commit
that referenced
this pull request
Nov 8, 2025
Summary: Pull Request resolved: #752 Add python tests for marker sequence io in fbx and the unified save function. Reviewed By: jeongseok-meta Differential Revision: D85739418
yutingye
added a commit
that referenced
this pull request
Nov 8, 2025
Summary: Pull Request resolved: #752 Add python tests for marker sequence io in fbx and the unified save function. Reviewed By: jeongseok-meta Differential Revision: D85739418
yutingye
added a commit
that referenced
this pull request
Nov 8, 2025
Summary: Pull Request resolved: #752 Add python tests for marker sequence io in fbx and the unified save function. Reviewed By: jeongseok-meta Differential Revision: D85739418
facebook-github-bot
temporarily deployed
to
pypi-cpu
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
pypi-cpu
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
pypi-gpu
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
pypi-gpu
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D85739418