Add a consolidated struct FileSaveOptions for both gltf and fbx options #770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 2, 2025
…ns (#770) Summary: This change adds a new struct to consolidate file saving options. It is not yet being used. Follow up diffs will start to update the code. Differential Revision: D86034154
yutingye
force-pushed
the
export-D86034154
branch
from
ad1ce77 to
176c8f0
Compare
yutingye
force-pushed
the
export-D86034154
branch
from
176c8f0 to
2a47367
Compare
yutingye
force-pushed
the
export-D86034154
branch
from
2a47367 to
127cdeb
Compare
yutingye
force-pushed
the
export-D86034154
branch
from
127cdeb to
ece3107
Compare
Summary: Pull Request resolved: #753 After D85530152 added marker sequence support to fbx, we have functionality parity between fbx and gltf. This diff created a unified `saveCharacter()` function in `character_io` that automatically selects between FBX and GLTF export based on file extension. Added .fbx support to `loadMarkers()` as the unified function for loading marker data from any supported format. Added an additional unified `saveCharacter()` function in `character_io` that takes skeleton states as input instead of model parameters. Rename `saveCharacter()` in `gltf_io` to `saveGltfCharacter()`, but keeping the existing ones for backwards compatibility for now. It will be removed in a later diff when downstreams are updated. Differential Revision: D85517572
Summary: Pull Request resolved: #752 Add python tests for marker sequence io in fbx and the unified save function. Reviewed By: jeongseok-meta Differential Revision: D85739418
Differential Revision: D86017756
yutingye
force-pushed
the
export-D86034154
branch
from
ece3107 to
683f69f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This change adds a new struct to consolidate file saving options. It is not yet being used. Follow up diffs will start to update the code.
Differential Revision: D86034154