Add round-trip test for parameter transform. #788
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 7, 2025
Summary: I want to do some refactoring of the parameter transform, so having some test coverage is helpful. Let's also add the ability to save out the parameter transform, which is useful in this test and could be useful in the future. Reviewed By: jeongseok-meta, cstollmeta Differential Revision: D86350961
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 7, 2025
Summary: I want to do some refactoring of the parameter transform, so having some test coverage is helpful. Let's also add the ability to save out the parameter transform, which is useful in this test and could be useful in the future. Reviewed By: jeongseok-meta, cstollmeta Differential Revision: D86350961
Summary: Pull Request resolved: #788 I want to do some refactoring of the parameter transform, so having some test coverage is helpful. Let's also add the ability to save out the parameter transform, which is useful in this test and could be useful in the future. Reviewed By: jeongseok-meta, cstollmeta Differential Revision: D86350961
cdtwigg
force-pushed
the
export-D86350961
branch
from
e7a6079 to
87664b2
Compare
Contributor
|
This pull request has been merged in 9c135d8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: I want to do some refactoring of the parameter transform, so having some test coverage is helpful. Let's also add the ability to save out the parameter transform, which is useful in this test and could be useful in the future.
Reviewed By: jeongseok-meta, cstollmeta
Differential Revision: D86350961