Repository navigation
fix(invite): enforce invitee ownership on accept and delete - #436
Merged
Merged
Conversation
Accept took organisation_id and role from the request body and never checked the invitation belonged to the caller, letting any user join any organisation with any role. It also wrote the Keto tuple before the DB row and continued past the "already a member" check, which could leave an orphaned owner tuple. Accept now loads the caller's own pending, unexpired invitation (row locked), takes organisation and role from it, returns on existing membership, and writes Keto last, removing the tuple if commit fails. Delete now only removes invitations addressed to the caller and returns 404 otherwise. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Deploying kavach-docs with
|
| Latest commit: |
ec4d405
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6e4a58ca.kavach-docs.pages.dev |
| Branch Preview URL: | https://fix-accept-invite-authz.kavach-docs.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept took organisation_id and role from the request body and never checked the invitation belonged to the caller, letting any user join any organisation with any role. It also wrote the Keto tuple before the DB row and continued past the "already a member" check, which could leave an orphaned owner tuple.
Accept now loads the caller's own pending, unexpired invitation (row locked), takes organisation and role from it, returns on existing membership, and writes Keto last, removing the tuple if commit fails.
Delete now only removes invitations addressed to the caller and returns 404 otherwise.