Skip to content

Conversation

@ekoops
Copy link
Contributor

@ekoops ekoops commented Dec 10, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area cmd

/area pkg

/area docs

/area tests

What this PR does / why we need it:

#404 introduced CMAKE_VERSION build arg but only the image/builder Makefile target indeed passed a value for it. This PR aligns passes the build arg also in push/builder and push/latest.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@poiana poiana added kind/bug Something isn't working dco-signoff: yes area/build Further information is requested labels Dec 10, 2025
@poiana poiana added the size/S label Dec 10, 2025
@irozzo-1A
Copy link

/lgtm

@leogr
Copy link
Member

leogr commented Dec 10, 2025

/override "[build-test-dev (amd64) / build-test"

@leogr
Copy link
Member

leogr commented Dec 10, 2025

/override "build-test-dev (amd64) / build-test"

@leogr
Copy link
Member

leogr commented Dec 10, 2025

/override "CI Build / build-test-dev (amd64) / build-test (pull_request)"

@poiana
Copy link

poiana commented Dec 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, irozzo-1A, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ekoops
Copy link
Contributor Author

ekoops commented Dec 10, 2025

Poiana come on!

@leogr
Copy link
Member

leogr commented Dec 10, 2025

/hold

@leogr
Copy link
Member

leogr commented Dec 10, 2025

/remove-hold

@leogr
Copy link
Member

leogr commented Dec 10, 2025

For the record, I'm going to merge this manually to overcome a CI issue.

@leogr leogr merged commit f59dff0 into falcosecurity:master Dec 10, 2025
5 of 7 checks passed
@ekoops ekoops deleted the ekoops/fix-push-makefile branch December 10, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/build Further information is requested dco-signoff: yes kind/bug Something isn't working lgtm size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants