-
Notifications
You must be signed in to change notification settings - Fork 53
fix(Makefile): pass build args to push/{builder,latest}
#405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Leonardo Di Giovanna <[email protected]>
|
/lgtm |
|
/override "[build-test-dev (amd64) / build-test" |
|
/override "build-test-dev (amd64) / build-test" |
|
/override "CI Build / build-test-dev (amd64) / build-test (pull_request)" |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekoops, irozzo-1A, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Poiana come on! |
|
/hold |
|
/remove-hold |
|
For the record, I'm going to merge this manually to overcome a CI issue. |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
#404 introduced
CMAKE_VERSIONbuild arg but only theimage/builderMakefile target indeed passed a value for it. This PR aligns passes the build arg also inpush/builderandpush/latest.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: