Skip to content

sync(0.22.2): fix(userspace/libsinsp): correct fallback for arg-less proc.* fields #2708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2025
Merged

sync(0.22.2): fix(userspace/libsinsp): correct fallback for arg-less proc.* fields #2708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 19 additions & 37 deletions userspace/libsinsp/sinsp_filtercheck_thread.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -836,10 +836,8 @@ int32_t sinsp_filter_check_thread::parse_field_name(std::string_view val,
try {
res = extract_arg("proc.apid", val, NULL);
} catch(...) {
if(val == "proc.apid") {
m_argid = -1;
res = (int32_t)val.size();
}
m_argid = -1;
res = static_cast<int32_t>(std::size("proc.apid")) - 1;
}

return res;
Expand All @@ -852,10 +850,8 @@ int32_t sinsp_filter_check_thread::parse_field_name(std::string_view val,
try {
res = extract_arg("proc.aname", val, NULL);
} catch(...) {
if(val == "proc.aname") {
m_argid = -1;
res = (int32_t)val.size();
}
m_argid = -1;
res = static_cast<int32_t>(std::size("proc.aname")) - 1;
}

return res;
Expand All @@ -868,10 +864,8 @@ int32_t sinsp_filter_check_thread::parse_field_name(std::string_view val,
try {
res = extract_arg("proc.aexepath", val, NULL);
} catch(...) {
if(val == "proc.aexepath") {
m_argid = -1;
res = (int32_t)val.size();
}
m_argid = -1;
res = static_cast<int32_t>(std::size("proc.aexepath")) - 1;
}

return res;
Expand All @@ -887,10 +881,8 @@ int32_t sinsp_filter_check_thread::parse_field_name(std::string_view val,
try {
res = extract_arg("proc.aexe", val, NULL);
} catch(...) {
if(val == "proc.aexe") {
m_argid = -1;
res = (int32_t)val.size();
}
m_argid = -1;
res = static_cast<int32_t>(std::size("proc.aexe")) - 1;
}

return res;
Expand All @@ -903,10 +895,8 @@ int32_t sinsp_filter_check_thread::parse_field_name(std::string_view val,
try {
res = extract_arg("proc.acmdline", val, NULL);
} catch(...) {
if(val == "proc.acmdline") {
m_argid = -1;
res = (int32_t)val.size();
}
m_argid = -1;
res = static_cast<int32_t>(std::size("proc.acmdline")) - 1;
}

return res;
Expand All @@ -919,10 +909,8 @@ int32_t sinsp_filter_check_thread::parse_field_name(std::string_view val,
try {
res = extract_arg("proc.aargs", val, NULL);
} catch(...) {
if(val == "proc.aargs") {
m_argid = -1;
res = (int32_t)val.size();
}
m_argid = -1;
res = static_cast<int32_t>(std::size("proc.aargs")) - 1;
}

return res;
Expand All @@ -935,10 +923,8 @@ int32_t sinsp_filter_check_thread::parse_field_name(std::string_view val,
try {
res = extract_arg("proc.env", val, NULL);
} catch(...) {
if(val == "proc.env") {
m_argname.clear();
res = (int32_t)val.size();
}
m_argname.clear();
res = static_cast<int32_t>(std::size("proc.env")) - 1;
}

return res;
Expand All @@ -951,10 +937,8 @@ int32_t sinsp_filter_check_thread::parse_field_name(std::string_view val,
try {
res = extract_arg("proc.args", val, NULL);
} catch(...) {
if(val == "proc.args") {
m_argid = -1;
res = (int32_t)val.size();
}
m_argid = -1;
res = static_cast<int32_t>(std::size("proc.args")) - 1;
}

return res;
Expand All @@ -967,11 +951,9 @@ int32_t sinsp_filter_check_thread::parse_field_name(std::string_view val,
try {
res = extract_arg("proc.aenv", val, NULL);
} catch(...) {
if(val == "proc.aenv") {
m_argname.clear();
m_argid = -1;
res = (int32_t)val.size();
}
m_argname.clear();
m_argid = -1;
res = static_cast<int32_t>(std::size("proc.aenv")) - 1;
}

return res;
Expand Down
Loading