Skip to content

Document handling of default values in API attributes #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Document handling of default values in API attributes #1116

wants to merge 5 commits into from

Conversation

@kpfleming
Copy link
Contributor

@kpfleming kpfleming commented Oct 1, 2025

Change summary

This PR provides documentation on how developers working on this provider should address the behavior of the Fastly API when dealing with default values for resource attributes.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

@kpfleming kpfleming added the Skip-Changelog Skip changelog build check label Oct 1, 2025
@kpfleming kpfleming added the Skip-Docs Used to skip the docs check for releases label Oct 1, 2025
anthony-gomez-fastly
anthony-gomez-fastly approved these changes Oct 1, 2025
View reviewed changes
Copy link
Contributor

@anthony-gomez-fastly anthony-gomez-fastly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

philippschulte
philippschulte reviewed Oct 2, 2025
View reviewed changes
Copy link
Member

@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together! It would be great if it would clarify how to handle non-matching scenarios. I think real-world examples would be helpful as well.

@kpfleming
Copy link
Contributor Author

kpfleming commented Oct 2, 2025

Some of that is coming soon :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philippschulte philippschulte philippschulte left review comments

@anthony-gomez-fastly anthony-gomez-fastly anthony-gomez-fastly approved these changes

Assignees

No one assigned

Labels

Skip-Changelog Skip changelog build check Skip-Docs Used to skip the docs check for releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kpfleming @philippschulte @anthony-gomez-fastly