Fixing bug where die can continue being rolled even if it's a player's turn to move (and hence die element shouldn't respond to double clicks temporarily). #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s turn to move (and hence die element shouldn't respond to double clicks temporarily).
Contributor
|
In the proposed solution, there is a lot of logic added to GtLudoGameElement>>#initializeFor:. A cleaner solution would be to have the GtLudoDieElement hold a reference to the game instead of the die (or instead of just the die), and then ask the game to roll the die. The game will then know if the die can be rolled. This would also require the initialization of the DieELement to be changed in GtLudoBoardElement>>#addDieElement. In this way we would keep game logic out of the UI elements. |
Contributor
|
Please leave this PR open and do not remove/delete it nor its origin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing bug where die can continue being rolled even if it's a player's turn to move (and hence die element shouldn't respond to double clicks temporarily).