Skip to content

Hotfix for Total Volume bug#1083

Merged
RemDelaporteMathurin merged 1 commit intofenicsxfrom
hotfix-total-volume
Mar 6, 2026
Merged

Hotfix for Total Volume bug#1083
RemDelaporteMathurin merged 1 commit intofenicsxfrom
hotfix-total-volume

Conversation

@RemDelaporteMathurin
Copy link
Collaborator

Description

Summary

For Discontinuous cases, the export_vol variable was defined in the wrong loop, leading to wrong results if surface fluxes were defined first or even errors if only TotalVolume quantities were defined.

Related Issues

Motivation and Context

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔨 Code refactoring (no functional changes, no API changes)
  • 📝 Documentation update
  • ✅ Test update (adding missing tests or correcting existing tests)
  • 🔧 Build/CI configuration change

Testing

  • All existing tests pass locally (pytest)
  • I have added new tests that prove my fix is effective or that my feature works

Code Quality Checklist

  • My code follows the code style of this project (Ruff formatted: ruff format .)
  • My code passes linting checks (ruff check .)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

Documentation

  • I have updated the documentation accordingly (if applicable)
  • I have added docstrings to new functions/classes following the project conventions

Breaking Changes

Screenshots/Examples

Additional Notes

@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.77%. Comparing base (b09927e) to head (2b3a99f).
⚠️ Report is 2 commits behind head on fenicsx.

Additional details and impacted files
@@           Coverage Diff            @@
##           fenicsx    #1083   +/-   ##
========================================
  Coverage    94.77%   94.77%           
========================================
  Files           44       44           
  Lines         3175     3175           
========================================
  Hits          3009     3009           
  Misses         166      166           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RemDelaporteMathurin RemDelaporteMathurin merged commit 2f470f1 into fenicsx Mar 6, 2026
16 of 18 checks passed
@RemDelaporteMathurin RemDelaporteMathurin deleted the hotfix-total-volume branch March 6, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant